Dear Marek Vasut,
In message 1346453055-30888-1-git-send-email-marex@denx.de you wrote:
Clean up a few things in STDIO. Mostly, don't export structures directly, but introduce some kind of accessors if needed and remove dead code.
NOTE: I'm still working on the "compile tested on 2 different architectures" part. I'll keep you posted about that. I'd be glad for a review though. I'd hate to pull in logic errors, especially into such critical code. NOTE2: Cross-posting cover to DM list, so I get feedback from those guys.
Marek Vasut (6): stdio: dm: Murder dead code in console.c stdio: dm: Add accessors to stdio_devices[] stdio: dm: Make stdio_devices[] local stdio: dm: Add stdio_fd_to_name() call stdio: dm: Use stdio_fd_to_name() call to localize stdio_names stdio: dm: Optimize stdio_print_current_devices()
I can't make heads nor tails from this patch series.
1) It was posted to the U-Boot list, but all patches carry a "dm:" in the subject, which does not appear to make sense to me, as at least some of the changes have no relation to DM work at all.
2) It appears this might be a RFC series, so why isn't it maked as such in the Subject: ?
3) It appears that some code gets added - what is the impact of these changes on the memory footprint?
4) Besides the dead code removal - what exactly is the purpose of these patches?
Best regards,
Wolfgang Denk