Re: [PATCH 06/20] binman: elf: Add more debugging to LookupAndWriteSymbols()

On 20/07/24 16:19, Simon Glass wrote:

When symbol-writing does not appear to work, it can sometimes be hard to figure out what is going on. Add some more debugging to help.

Signed-off-by: Simon Glass sjg@chromium.org

tools/binman/elf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/binman/elf.py b/tools/binman/elf.py index 2ecc95f7eb8..a4694056391 100644 --- a/tools/binman/elf.py +++ b/tools/binman/elf.py @@ -275,7 +275,7 @@ def LookupAndWriteSymbols(elf_fname, entry, section, is_elf=False, return 0 base = syms.get(base_sym) if not base and not is_elf:

•    tout.debug('LookupAndWriteSymbols: no base')
  

•    tout.debug(f'LookupAndWriteSymbols: no base: elf_fname={elf_fname}, base_sym={base_sym}, is_elf={is_elf}')
      return 0
  base_addr = 0 if is_elf else base.address
  count = 0
  

Reviewed-by: Neha Malcom Francis n-francis@ti.com