Re: [U-Boot] [PATCH 08/10] exynos: dts: Enable LCD for snow

Hi Simon,

Enable LCD for snow. This is a 1366 x 768 panel.

Signed-off-by: Simon Glass sjg@chromium.org

arch/arm/dts/exynos5250-snow.dts | 44 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)

diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts index 42a687b..725a1bf 100644 --- a/arch/arm/dts/exynos5250-snow.dts +++ b/arch/arm/dts/exynos5250-snow.dts @@ -192,4 +192,48 @@ /* UP LEFT */ 0x070b0067 0x070c0069>; };

• fimd@14400000 {

• samsung,vl-freq = <60>;
  

• samsung,vl-col = <1366>;
  

• samsung,vl-row = <768>;
  

• samsung,vl-width = <1366>;
  

• samsung,vl-height = <768>;
  

• samsung,vl-clkp;
  

• samsung,vl-dp;
  

• samsung,vl-hsp;
  

• samsung,vl-vsp;
  

• samsung,vl-bpix = <4>;
  

• samsung,vl-hspw = <32>;
  

• samsung,vl-hbpd = <80>;
  

• samsung,vl-hfpd = <48>;
  

• samsung,vl-vspw = <5>;
  

• samsung,vl-vbpd = <14>;
  

• samsung,vl-vfpd = <3>;
  

• samsung,vl-cmd-allow-len = <0xf>;
  

• samsung,winid = <0>;
  

• samsung,interface-mode = <1>;
  

• samsung,dp-enabled = <1>;
  

• samsung,dual-lcd-enabled = <0>;
  

• };

I can only now regret that we have not stick to the Linux kernel DTS format and be ABI compatible with Linux (and add u-boot specific bindings as an extension).

Now unfortunately it is too late.

• dp@145b0000 {

• samsung,lt-status = <0>;
  

• samsung,master-mode = <0>;
  

• samsung,bist-mode = <0>;
  

• samsung,bist-pattern = <0>;
  

• samsung,h-sync-polarity = <0>;
  

• samsung,v-sync-polarity = <0>;
  

• samsung,interlaced = <0>;
  

• samsung,color-space = <0>;
  

• samsung,dynamic-range = <0>;
  

• samsung,ycbcr-coeff = <0>;
  

• samsung,color-depth = <1>;
  

• };

};

Reviewed-by: Lukasz Majewski l.majewski@samsung.com