Re: [PATCH v5 02/10] lib: elf: Move the generic elf loading/validating functions to lib

On Tue, Jan 28, 2020 at 04:21:07PM +0530, Keerthy wrote:

Move the generic elf loading/validating functions to lib/ so that they can be re-used and accessed by code existing outside cmd.

Signed-off-by: Keerthy j-keerthy@ti.com Suggested-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com Reviewed-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com

[snip]

diff --git a/lib/elf.c b/lib/elf.c new file mode 100644 index 0000000000..c2097305ec --- /dev/null +++ b/lib/elf.c @@ -0,0 +1,256 @@ +/*

• • Copyright (c) 2001 William L. Pitts
• • All rights reserved.
• • Redistribution and use in source and binary forms are freely
• • permitted provided that the above copyright notice and this
• • paragraph and the following disclaimer are duplicated in all
• • such forms.
• • This software is provided "AS IS" and without any express or
• • implied warranties, including, without limitation, the implied
• • warranties of merchantability and fitness for a particular
• • purpose.
• */

Ah, I see. cmd/elf.c is missing the SPDX tag, which this also needs. I looked and I don't think it's fair to ask you to put the SDPX tag on cmd/elf.c so I'm going to update it to BSD-2-Clause. You should depend on that patch and use the same tag here.