On Tue, Jun 03, 2008 at 10:04:29AM -0500, Menon, Nishanth wrote:
Sascha,
-----Original Message----- From: Sascha Hauer [mailto:s.hauer@pengutronix.de] Sent: Tuesday, June 03, 2008 3:08 AM To: Menon, Nishanth Cc: u-boot-users@lists.sourceforge.net; Laurent Desnogues; dirk.behme@googlemail.com; philip.balister@gmail.com; Gopinath, Thara; Kamat, Nishant; Syed Mohammed, Khasim Subject: Re: [Patch 05/17] U-Boot-V2:ARM: Introduce capability to havedifferent stack/malloc area
This patch rises an issue we currently have in U-Boot-v2: We have as many stack/memory strategies as we have architectures :(
Instead of modifying this for one architecture I would prefer something like this (currently no implementation, only kconfig). Would this solve your issues?
Yes, :). Couple of minor comments though..
diff --git a/common/Kconfig b/common/Kconfig index 79a3684..d764482 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -19,13 +19,66 @@ menu "General Settings " config BOARDINFO string
+menu "memory layout "
Curious: Why have the extra space? I see this in other places too.. it kind of messes up the defconfig with trailing spaces :(.
It's just to align the menu arrows nicely under each other in make menuconfig.
+choice
- prompt "select stack base policy"
s/stack/heap?
- depends on HAVE_CONFIGURABLE_MALLOC
+config MALLOC_BASE_DEFAULT
- bool
- prompt "place stack before U-Boot"
s/stack/heap?
No, this is the processor stack...
+config MALLOC_BASE_FIXED
- bool
- prompt "manually assign a malloc base"
...while this is the malloc heap.
+endchoice
+endmenu
Ack to the changes. This should be good for me.
Regards, Nishanth Menon