On Friday, December 11, 2015 at 03:59:14 PM, Jagan Teki wrote:
On 11 December 2015 at 02:57, Troy Kisky troy.kisky@boundarydevices.com
wrote:
If GENMASK is REALLY desired, it should be GENMASK(23,0) But since GENMASK is obviously more confusing, let's just revert.
This reverts commit bad490a24212c068c5b718b9189f47ea4075d078.
Sorry, just fix genmask why revert? because driver author has no complaint on this, please don't just say simply "more confusing" more over I usually prefer reverting bug fix patches.
I also agree this GENMASK() crap is confusing.
Reviewed-by: Fabio Estevam fabio.estevam@freescale.com Signed-off-by: Troy Kisky troy.kisky@boundarydevices.com
v2: add sign off/ reviewed by
drivers/spi/fsl_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index ed39114..dd7048a 100644 --- a/drivers/spi/fsl_qspi.c +++ b/drivers/spi/fsl_qspi.c @@ -24,7 +24,7 @@ DECLARE_GLOBAL_DATA_PTR;
#define TX_BUFFER_SIZE 0x40 #endif
-#define OFFSET_BITS_MASK GENMASK(24, 0) +#define OFFSET_BITS_MASK 0x00ffffff
#define FLASH_STATUS_WEL 0x02
-- 2.5.0
thanks!
Best regards, Marek Vasut