-----Original Message----- From: Albert ARIBAUD [mailto:albert.aribaud@free.fr] Sent: Tuesday, September 07, 2010 4:53 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Prabhanjan Sarnaik; Ashish Karkare Subject: Re: [PATCH V2] mvsata_ide: adjust port init sequence
Le 07/09/2010 08:42, Prafulla Wadaskar a écrit :
diff --git a/drivers/block/mvsata_ide.c
b/drivers/block/mvsata_ide.c
@@ -125,15 +129,17 @@ int ide_preinit(void)
return 1;How about returning negative values for errors ?
Function ide_preinit() is called from cmd_ide.c:ide_init(), which does not distinguish positive vs negative return values, ony zero vs non-zero. So what would be the point of returning negative rather than positive values?
Negative always represents errors, whereas positive may represent some valid return state. In this case it may not be that important.
Regards.. Prafulla . .
Amicalement,
Albert.