Tom,
I was not able to access this link But, yes, please include this patch as part of the tnetv107x patchset.
Sure. I will include this with the larger TNETV107X patchset and submit.
Until then, a code preview can be found at http://arago-project.org/git/people/?p=cyril/u-boot-tnetv107x.git;a=commit;h... (included a non-shortened URL this time).
Ok. Obviously it is better to generalize than to make off-by-one copies but not if there are not enough similarities to make it work..
Absolutely. In this particular case, it just happens to be the latter.
My concern is that start.S, because it came originally from s3c64xx, may need to either generalized or split up. With s3c64xx parts moving to SOC layer. Assembly is complicated enough without having #if-def's and if can be done in C it should.
Indeed start.S needed to be generalized to an extent. Further, since similar generalizations existed on other ARM platforms, I figured it would be best to stick with the same scheme.
My only reservation is with the whole "peripheral port remap" thing. I think that this should ideally be moved into SOC specific lowlevel_init. However, I did not want to mangle up s3c64xx code too much by moving stuff around in this manner.
Any thoughts on this specific concern?
Please review http://www.denx.de/wiki/U-Boot/Patches, clean up the patchset and submit, having another arm1176 soc will be great.
Will do. Thanks.
Cyril.