On 07/17/2015 12:27 PM, Nishanth Menon wrote:
On 07/17/2015 10:38 AM, Murali Karicheri wrote:
On 07/16/2015 03:08 PM, Nishanth Menon wrote:
[...]
/* MMC/SD IP block */ #define CONFIG_MMC #define CONFIG_GENERIC_MMC
Why do we need MMC options in common? Only keystone device that uses MMC is Galileo. This should stay in individual device specific or board specific config file.
precisely why MMC is present in generic - lack of mmc is not consistent in all ks2 devices as well - we can #undef if as necessary. I did miss undefing it in patch #4 - I just did #undef CONFIG_SPL_MMC_SUPPORT
That will be fine. Thanks.
I can respin patch #4. with these added in.
-#define CONFIG_OMAP_HSMMC #define CONFIG_CMD_MMC
Same here..
ditto.
/* GPIO block */ -#define CONFIG_OMAP_GPIO #define CONFIG_CMD_GPIO
I believe currently keystone doesn't use GPIO, but this may change. Probably remove this as well for now and add it when GPIO is supported on K2.
patch #4:
+/* And no support for GPIO, yet.. */ +#undef CONFIG_SPL_GPIO_SUPPORT +#undef CONFIG_CMD_GPIO
idea being to have as many common definitions as possible and undef the ones we dont need as necessary. only thing i was careful here about was to try and remove all OMAP specific defines out.