+Simon,
Hi Andy,
On Wed, Jul 5, 2017 at 9:09 PM, Tom Rini trini@konsulko.com wrote:
On Wed, Jul 05, 2017 at 08:19:27PM +0800, Bin Meng wrote:
+Marek,
Hi Andy,
On Wed, Jul 5, 2017 at 5:36 PM, Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Wed, Jul 5, 2017 at 12:36 PM, Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Wed, Jul 5, 2017 at 8:23 AM, Bin Meng bmeng.cn@gmail.com wrote:
So, options are:
- apply my patch
- remove selection of the host at least for X86.
- move hosts out of "if USB".
- select USB in USB_EHCI_HCD?
Not sure which option is the best way.
So, to be clear, CONFIG_USB is not used in the code. It's a Kconfig-only option we can / should use to make navigation and dependencies easier. I would think that USB needs to be enabled for any USB-related choice to be visible (so things can depends on USB or be hidden under if USB, depending on overall file context).
So I would expect X86 (and most ARCH_xxx under ARM and other cases) to at least imply USB, if not select it.
And peeking at the kernel, this maybe should be CONFIG_USB_SUPPORT not CONFIG_USB, to be clearer?
If we don't hear comments from others, let's do like what you proposed, but please also update other x86 boards defconfig files to remove CONFIG_USB there.
Regards, Bin