Hallo Moritz,
Am 12.09.2017 um 06:27 schrieb Heiko Schocher:
Hello Moritz,
Am 11.09.2017 um 20:19 schrieb Moritz Fischer:
This commit adds support for GPIO reset lines matching the common linux "reset-gpios" devicetree binding.
Signed-off-by: Moritz Fischer moritz.fischer@ettus.com
Changes from v1:
- Simon's feedback on ifdef vs IS_ENABLED()
drivers/i2c/muxes/pca954x.c | 42 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-)
Reviewed-by: Heiko Schocher hs@denx.de
Hmm.. your patch
http://patchwork.ozlabs.org/patch/812541/
breaks the mvebu travis build, see:
https://travis-ci.org/hsdenx/u-boot-i2c/jobs/274457946
for example: arm: + turris_omnia +drivers/i2c/muxes/pca954x.c: In function ?pca954x_probe?: +drivers/i2c/muxes/pca954x.c:120:10: error: ?struct pca954x_priv? has no member named ?gpio_mux_reset? + &priv->gpio_mux_reset, GPIOD_IS_OUT); + ^~
but your patch seems to do it correct:
+ if (IS_ENABLED(CONFIG_DM_GPIO)) {
Hmm... I know Simon suggested exactly this change ... but this seems to produce errors here ... when I look into the ".config" file after
"make turris_omnia_defconfig"
I see:
# CONFIG_DM_GPIO is not set
Hmm... using
#ifdef CONFIG_DM_GPIO
instead "if (IS_ENABLED(CONFIG_DM_GPIO)) {" and it compiles clean.
So it seems we have a problem here with "IS_ENABLED()" ...
@Simon, Masahiro: any ideas?
bye, Heiko