Re: [U-Boot] [PATCH] Fix debug output.

Dear Thomas Weber,

In message 1260177679-18337-1-git-send-email-weber@corscience.de you wrote:

Signed-off-by: Thomas Weber weber@corscience.de

drivers/net/dm9000x.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index 73dd335..08bd794 100644 --- a/drivers/net/dm9000x.c +++ b/drivers/net/dm9000x.c @@ -74,8 +74,8 @@ TODO: external MII is not functional, only internal at the moment. #define DM9000_DBG(fmt,args...) printf(fmt, ##args) #define DM9000_DMP_PACKET(func,packet,length) \ do { \

• int i; 							\
  

• printf(func ": length: %d\n", length);			\
  

• 	int i; 							\
  

• printf("%s: length: %d\n",func, length);			\
  

  for (i = 0; i < length; i++) { \ if (i % 8 == 0) \ printf("\n%s: %02x: ", func, i); \

Which problem is this supposed to fix?

Actually this patch introduces two new issues (the "int i;" line uses spaces for indentation, and the '' are not vertically aligned any more).

NAK.

Best regards,

Wolfgang Denk