On 10. 10. 19 19:06, Simon Glass wrote:
Hi Michal,
On Thu, 10 Oct 2019 at 05:44, Michal Simek michal.simek@xilinx.com wrote:
Extend test suite to cover also automatic octal/hex converstions which haven't been implemented in past.
Signed-off-by: Michal Simek michal.simek@xilinx.com
Depends on https://lists.denx.de/pipermail/u-boot/2019-September/383309.html
There are of course other tests which we can run but not sure if make sense to have there all combinations. The most interesting are mixed tests which are failing before patch above is applied. Definitely please let me know if you want to add any other test.
test/py/tests/test_hush_if_test.py | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
I worry that these tests might be very slow since it requires a lot of interaction with U-Boot over a pipe. Is it possible to put them in C code instead, e.g. cmd_ut?
I have of course running it on my HW and it is quite fast. It is just 16 more simple tests. And if this breaks gitlab/travis CI loops then we have bigger problem. I see that CONFIG_UNIT_TEST is enabled only for sandbox. Do it make sense to enable it also for others to have better coverage?
Thanks, Michal