22 Jan
2015
22 Jan
'15
5:24 a.m.
On 22/01/15 10:24, Marek Vasut wrote:
On Wednesday, January 21, 2015 at 12:55:14 PM, Graeme Russ wrote:
Signed-off-by: Graeme Russ gruss@tss-engineering.com
Hi!
- Commit message is missing.
- Some of the debug outputs are missing newline (\n) character
- You can use __func__ and __LINE__ in the debug output to better specify where the debug spit happened.
I saw something earlier on the list about this - I thought the feeling was to use descriptive strings that are easy to grep rather than __func__ and __LINE__, or maybe I misread
Oh, and the CC list looks pretty random. You can just add "Cc: " tag into the patches so that git handles it correctly.
Cc list was generated by patman (I added Damien as his patch is what mine are based on)
Regards,
Graeme