Dear Tom,
In message 20210812162034.GY858@bill-the-cat you wrote:
So if "the system is on fire" is one of the cases where an error message should be omitted to save maybe 50 or 100 bytes of image size? This sounds wrong to me.
It sounds right to me because it's unlikely everything caught fire because of this call right here and likely it's because of one of the messages much further up on the console log. Hopefully we haven't caused that message to be unavailable now due to unhelpful failure messages.
Omitting code to handle situations that are unlikely to happen is definitely not what I consider robust programming, and nothing which I would let pass a code review.
But if you insist, there is no more to do for me here that to note that fact that we disagree.
Wolfgang Denk