Re: [U-Boot] [PATCH v10] Marvell MV88F6281GTW_GE Board support

• */

+#include <common.h> +#include <netdev.h> +#include <asm/arch/kirkwood.h> +#include <asm/arch/mpp.h> +#include "mv88f6281gtw_ge.h"

please move the mv88f6281gtw_ge.h to include/asm-arm/arch-kirkwood/

+DECLARE_GLOBAL_DATA_PTR;

+int board_init(void) +{

• /*

• * default gpio configuration
  

• * There are maximum 64 gpios controlled through 2 sets of registers
  

• * the  below configuration configures mainly initial LED status
  

• */
  

• kw_config_gpio(MV88F6281GTW_GE_OE_VAL_LOW,

• 	MV88F6281GTW_GE_OE_VAL_HIGH,
  

• 	MV88F6281GTW_GE_OE_LOW, MV88F6281GTW_GE_OE_HIGH);
  

• /* Multi-Purpose Pins Functionality configuration */
• u32 kwmpp_config[] = {

do you really need to configure all of this IO?

• MPP0_SPI_SCn,
  

• MPP1_SPI_MOSI,
  

• MPP2_SPI_SCK,
  

• MPP3_SPI_MISO,
  

please add a device init api as done for davinci or at91 (could be done in an other patch)

• MPP4_GPIO,
  

• MPP5_GPO,
  

• MPP6_SYSRST_OUTn,
  

• MPP7_SPI_SCn,
  

• MPP8_TW_SDA,
  

Best Regards, J.