1 Aug
2012
1 Aug
'12
6:22 a.m.
On 07/31/2012 08:31 PM, Vikram Narayanan wrote:
On 7/31/2012 11:18 PM, Vikram Narayanan wrote:
Driver for BCM2835 SoC. This gives the basic functionality of setting/clearing the output.
diff --git a/arch/arm/include/asm/arch-bcm2835/gpio.h
+#define BCM2835_GPIO_COUNT 53
GPIO count should be 54 to make the gpio_is_valid work correctly when the gpio is 53. Will fix in v4.
Oh dear. I posted an updated version of your patches which fix a bunch of errors. I guess I'll wait and see if there are any other comments on other patches in that series, and re-post that series, or just that patch, with that fixed later.
P.S. There's no need to quote the entire patch just to comment on one line.