Hi Stephen,
On Tue, 27 Nov 2012 09:32:27 -0700, Stephen Warren swarren@wwwdotorg.org wrote:
On 11/26/2012 11:49 PM, Albert ARIBAUD wrote:
On Mon, 26 Nov 2012 21:38:16 -0700, Stephen Warren swarren@wwwdotorg.org wrote:
This adds a simple driver for the BCM2835's SD controller.
Workarounds are implemented for:
- Register writes can't be too close to each-other in time, or they will be lost.
- Register accesses must all be 32-bit, so implement custom accessors.
This code was extracted from: git://github.com/gonzoua/u-boot-pi.git master which was created by Oleksandr Tymoshenko.
Portions of the code there were obviously based on the Linux kernel at: git://github.com/raspberrypi/linux.git rpi-3.6.y commit f5b930b "Main bcm2708 linux port" signed-off-by Dom Cobley.
swarren changed the following for upstream:
- Removed hack udelay()s in bcm2835_sdhci_raw_writel(); setting SDHCI_QUIRK_WAIT_SEND_CMD appears to solve the issues.
- Remove register logging from read*/write* functions.
- Sort out confusion with min/max_freq values passed to add_sdhci().
- Use more descriptive variable names and calculations in IO accessors.
- Simplified and commented twoticks_delay calculation.
- checkpatch fixes.
Cc: Andy Fleming afleming@gmail.com
Hi Andy,
As soon as you give your Ack to this patch, I'll apply the whole series to u-boot-arm/master.
Do feel free to apply all the patches before the MMC driver addition without waiting for the MMC driver though.
You're right. I'll apply 1 to 5 and wait for Andy's comment to be taken into account for applying 6 and 7, possibly in a newer version.
Amicalement,