Hello Trent,
Am 16.04.2019 um 00:02 schrieb Trent Piepho:
It is not very clear how these work in relation to the exact I2C xfers they produce. In paticular, the address length is somewhat overloaded in the read method. Clearly document the existing behavior. Maybe this will help the next person who needs to work on this driver and not break non-DM boards.
Cc: Nandor Han nandor.han@ge.com Cc: Heiko Schocher hs@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Fabio Estevam festevam@gmail.com Cc: Breno Matheus Lima brenomatheus@gmail.com Signed-off-by: Trent Piepho tpiepho@impinj.com
drivers/i2c/mxc_i2c.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
Thanks, but your patch has a lot of checkpatch errors:
total: 34 errors, 0 warnings, 0 checks, 52 lines checked
please fix this and send a v2.
Reviewed-by: Heiko Schocher hs@denx.de
bye, Heiko