Dear Matt Sealey,
I'm gonna NACK this because most of these pin settings are actually the POR defaults anyway (UART1 is the example I can easily pick out).
.. unless someone's setting them up wrong between warn reboots, or changing a UART into something else later in boot.. which is unfathomable.. we don't need to even touch the iomux controller to get a working UART on MX51, Efika MX or anything.
Why bother touching them?
I agree, but the purpose of this patch is not to add this code, only to move it to a common place... Why didn't you NAK the addition of these boards because of that?
This kind of code is present in all i.MX board files. If it is useful, it's better to have it merged rather than duplicated. If it is useless, then it can be removed from all boards.
If you NAK this, following your rationale, it means that you prefer to have useless duplicated code everywhere rather than in a single location. This just doesn't make any sense. Or are you suggesting to remove this code from all boards instead? Was there a good reason for this code to be there in the first place?
Best regards, Benoît