20 Dec
2011
20 Dec
'11
7:23 p.m.
On Dec 20, 2011, at 13:20, Mike Frysinger wrote:
On Tuesday 20 December 2011 12:41:12 Kyle Moffett wrote:
--- a/fs/fat/fat.c +++ b/fs/fat/fat.c
+static disk_partition_t cur_part_info = {
- .start = 0,
- .size = 0,
- .blksz = 512,
- .name = "",
- .type = "",
+};
there any way we could delay that initialization of blksz to runtime ? if that wasn't there, cur_part_info would be in .bss instead of .data.
I redid this patch several times before I figured out what was going on and I ended up with both paths fully initializing this struct, so there's really no need for an initializer at all.
I'll remove it for the next round.
Thanks for the review!
Cheers, Kyle Moffett
-- Curious about my work on the Debian powerpcspe port? I'm keeping a blog here: http://pureperl.blogspot.com/