Hi Andre,
On Wed, Sep 25, 2013 at 4:42 AM, Andre Przywara andre.przywara@linaro.orgwrote:
Hi,
while working on HYP mode support for Exynos 5250 based boards, I fixed some shortcomings in their configuration files.
The purpose of this series is to get rid of the elaborate arndale.h and replace it mostly by an include of exynos5250-dt.h, which currently has an about 90% overlap. I couldn't find any prior art, please bear with me if I have missed something on the list.
- Patch 1 fixes a bug, where PMIC support would not have been included
in the Arndale build.
- Patch 2 removes double definitions.
Those two should be considered regardless of the others.
- Patch 3 prepares the consolidation of the config files by moving
board specific defines out of the generic file.
- Patch 4 makes keyboard and LCD support board dependent, please have
a closer look at this. I guess SMDK5250 does not have the EC, but it breaks compilation if that is excluded.
- Patch 5 then finally removes the now redundant defines in arndale.h
and replaces them with an include of exynos5250-dt.h.
This series is mostly refactoring, though the config options change a bit for some boards. I could only compile test it, so please test it if you have the hardware.
I'd like to adjust the approach slightly. The idea with exynos5250-dt.h is that it mirrors the exynos5250-dt.c file in the kernel - it is intended that we can create a U-Boot that will run on any Exynos 5250 board, with an appropriate device tree file provided. In short I'd like to create an 'exynos5250-dt' board config.
Your series moves towards exynos5250-dt.h just being a common file used by many boards. So can we rename this file, perhaps to exynos5250-common.h, before making your changes? Then I can do a patch to add the generic Exynos5250 board.
Regards, Simon
Thanks! Andre
Signed-off-by: Andre Przywara andre.przywara@linaro.org
Andre Przywara (5): ARM: Exynos5250: rename obsoleted CONFIG_PMIC defines ARM: Exynos5250: remove redundant defines in exynos5250-dt.h ARM: Exynos5250: move feature defines out of generic config file ARM: snow: move defines for Chromebook embedded controller ARM: Arndale: include generic exynos5250-dt.h in arndale.h
drivers/power/power_fsl.c | 2 +- include/configs/arndale.h | 242 +--------------------------------------- include/configs/exynos5250-dt.h | 63 ++++------- include/configs/smdk5250.h | 11 +- include/configs/snow.h | 11 +- 5 files changed, 47 insertions(+), 282 deletions(-)
-- 1.7.12.1