Hi Marek,
On 08/16/2016 03:41 PM, Lukasz Majewski wrote:
Hi Marek,
Hi,
is that for master or next ?
This patch _was_ supposed to go to "master"
Was this build tested ?
Unfortunately, not so thoroughly as I thought.
Moving dfu code to SPL causes following error on some boards:
arm: + smartweb +In file included from ../include/dfu.h:18:0, + from ../common/dfu.c:16: +../include/linux/usb/composite.h:331:9: error: requested alignment is not an integer constant + struct usb_device_descriptor __aligned(CONFIG_SYS_CACHELINE_SIZE) desc; + ^ +make[3]: *** [spl/common/dfu.o] Error 1 +make[2]: *** [spl/common] Error 2 +make[1]: *** [spl/u-boot-spl] Error 2 +make: *** [sub-make] Error 2
Ravi, to reproduce you need to fetch u-boot-dfu/test
and run buildman:
This is only a small subset of affected boards, so please test also "arm" (which might take long time).
./tools/buildman/buildman.py --branch=HEAD siemens --detail --verbose --show_errors --force-build --count=5 --output-dir=./BUILD/
Thanks Marek, for pointing out.
Please find following code for u-boot-dfu repository.
The following changes since commit 76b2fad775ee3cb58788b11454655ba5a244ac56:
eth: asix88179: Add support for the driver model (2016-08-09 12:52:05 +0200)
are available in the git repository at:
ssh://gu-dfu@git.denx.de/u-boot-dfu e8091b356dd0f1e8e742a5da7a5e8256744b39b7
for you to fetch changes up to e8091b356dd0f1e8e742a5da7a5e8256744b39b7:
cmd: dfu: Add error handling for failed registration (2016-08-16 13:06:04 +0200)
B, Ravi (5): spl: dfu: add dfu support in SPL common: dfu: saperate the dfu common functionality spl: dfu: adding dfu support functions for SPL-DFU dra7x: boot: add dfu bootmode support dra7x: configs: enable SPL-DFU support
Sanchayan Maity (1): cmd: dfu: Add error handling for failed registration
Kconfig | 27 +++++++++++++++++++++++++++ arch/arm/cpu/armv7/omap-common/boot-common.c | 5 +++++ arch/arm/include/asm/arch-omap5/spl.h | 2 +- cmd/dfu.c | 61 ++----------------------------------------------------------- common/Makefile | 3 +++ common/dfu.c | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ common/spl/Makefile | 1 + common/spl/spl.c | 10 +++++++++- common/spl/spl_dfu.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/configs/dra7xx_evm.h | 20 +++++++++++++++++++- include/configs/ti_omap5_common.h | 2 -- include/g_dnl.h | 1 + include/spl.h | 8 ++++++++ scripts/Makefile.spl | 4 ++++ 14 files changed, 229 insertions(+), 64 deletions(-) create mode 100644 common/dfu.c create mode 100644 common/spl/spl_dfu.c
Test HW: Exynos 4412 Odroid U3, Exynos5422 Odroid XU3 Tested-by: Lukasz Majewski l.majewski@samsung.com
by HWT system