Ian,
On Thu, Jan 12, 2012 at 08:01:45AM +0000, Ian Campbell wrote:
On Sun, 2012-01-08 at 17:54 -0500, Jason wrote:
On Sun, Jan 08, 2012 at 07:49:05PM +0000, Ian Campbell wrote:
On Sun, 2012-01-08 at 15:30 +0000, Ian Campbell wrote: diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c index dfe542d..db8ba8b 100644 --- a/drivers/spi/kirkwood_spi.c +++ b/drivers/spi/kirkwood_spi.c @@ -66,7 +66,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, debug("data = 0x%08x \n", data);
writel(KWSPI_SMEMRDIRQ, &spireg->irq_cause);
- writel(KWSPI_IRQMASK, spireg->irq_mask);
writel(KWSPI_IRQMASK, &spireg->irq_mask);
/* program mpp registers to select SPI_CSn */ if (cs) {
-- 1.7.5.4
Acked-By: Jason Cooper u-boot@lakedaemon.net
Dammit. My apologies. I should've caught that. Thanks for the patch.
No problem, was interesting to dig into u-boot for the first time!
Well, at least my mistake created another u-boot hacker. ;-)
Did I get the CC list right to cover whoever will eventually apply this patch?
Meh, I've been pondering this. The merge window is open right now, go ahead and resubmit according to [1]. Make sure to put the Message-Id: of the original patch email you sent as an In-Reply-To:, and mention in the changelog that this 'v2' follows [1] for patch submissions.
Also, make sure Prafulla and Albert are in the CC if they aren't already.
I think the original will get lost in the shuffle because it doesn't have [PATCH 1/1] in the subject line.
You are also working on upstreaming dreamplug support into Linux, is that right? What is the current state of the art? I'm currently using a 3.1 kernel + patches from http://people.debian.org/~zumbi/dreamplug/patches/ . (BTW feel free to reply off list or switch to e.g. linux-arm-kernel since I guess this is strict speaking off-topic here).
I use this [2] for 3.1, since it uses the same nor flash partitioning as u-boot does. This way, you could edit the u-boot config from userspace or upgrade u-boot from userspace.
hth,
Jason.
[1] http://www.denx.de/wiki/U-Boot/Patches [2] http://permalink.gmane.org/gmane.linux.ports.arm.kernel/143116