Hi Brian,
You are getting closer! :-) For perfection, you need to adjust a few things. First, make your mail Subject: line be a concise one-line summary of your patch prefixed with a "[PATCH]" so we can spot it, and then launch into the rest of your log message.
Secondly, non-log commentary like this:
On Thu, 2007-12-13 at 20:23, raptorbrino@aim.com wrote:
Sorry guys, first time posting a patch and I believe the formatting of my last mail was all wrong. Here's a better attempt at it.
belongs after a "---" line, but before your diff content.
This patch allows u-boot to build without error in a cygwin environment. Cygwin does not define __u64 in it's include/asm/types.h file. The -idirafter flag in the u-boot build causes the inclusion of the cygwin types.h file as opposed to u-bot/include/asm/types.h file which does define __u64. Subsequently, sha1.c compile fails due to unknown symbol.
Signed-off-by: Brian Miller raptorbrino@netscape.net
Right here! Like this:
---
Additional commentary here....
and then your patch!
diff -purN old/tools/Makefile new/tools/Makefile --- old/tools/Makefile 2007-12-06 01:21:19.000000000 -0800 +++ new/tools/Makefile 2007-12-13 12:22:15.796875000 -0800 @@ -97,6 +97,7 @@ endif # ifeq ($(HOSTOS),cygwin) SFX = .exe +HOST_CFLAGS += -ansi else SFX = endif
Keep up the good fight!
Good luck, jdl