Dear Joe Hershberger,
In message 1337108353-28086-2-git-send-email-joe.hershberger@ni.com you wrote:
Signed-off-by: Joe Hershberger joe.hershberger@ni.com Cc: Joe Hershberger joe.hershberger@gmail.com
Changes for v2:
- Remove volatile from eth driver API
- Not using global NetRxPacket (since not casting away volatile)
Changes for v3:
include/net.h | 25 +++++++++++++------------ net/bootp.c | 4 ++-- net/eth.c | 12 +++++------- net/net.c | 34 +++++++++++++++++----------------- net/rarp.c | 2 +- net/tftp.c | 6 +++--- 6 files changed, 41 insertions(+), 42 deletions(-)
While getting rid of volatile is a good thing in general, I am worried about the test scope of this patch.
This commit is causing tons of compiler warnings because the respective changes have only be done in the header file and the net/ code, but they are missing in _all_ network drivers. I wonder which compile and run time testing has been done with this? I mean, you decided to pull this into mainline - has it been tested at all ?!?
When are you planning to provide fixes for all these warnings? As is, the whole build is spoiled. Or should we revert these patches?
Best regards,
Wolfgang Denk