Re: [U-Boot] [PATCH] armv8: Support loading 32-bit OS which is not in the form of FIT

On Tue, Jun 06, 2017 at 03:32:40PM +0800, Alison Wang wrote:

As only FIT image is supported now, this patch is to support loading 32-bit uImage, dtb and rootfs separately.

Signed-off-by: Alison Wang alison.wang@nxp.com

Reviewed-by: Tom Rini trini@konsulko.com

However, entirely unrelated, I found this while reviewing the patch: $ grep IH_ARCH_ arch/arm/include/asm/arch-fsl-layerscape/mp.h #define IH_ARCH_ARM 2 /* ARM */ #define IH_ARCH_ARM64 22 /* ARM64 */

And that's dangerous and whatever needs those defines needs to be using <image.h> instead where we have the canonical enum of those values. Please correct this, thanks!