3 Mar
2016
3 Mar
'16
5:58 p.m.
On 03/02/2016 05:25 PM, Simon Glass wrote:
Hi Stephen,
On 29 February 2016 at 16:39, Stephen Warren swarren@wwwdotorg.org wrote:
On 02/25/2016 09:00 PM, Simon Glass wrote:
Don't try to run commands when not supported.
diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c
+int board_run_command(const char *cmdline) +{
printf("## Commands are disabled. Please enableCONFIG_CMDLINE.\n");
return 1;+}
Isn't this part of patch 5/9?
No - this is the sandbox support. That patch merely declares the function in a header. Any board can implement it, and each would do so in a separate patch.
OK, but this patch implements the function before there's a prototype for it in the header. That doesn't seem like the correct order.