On 11/10/24 09:41, Ilias Apalodimas wrote:
On Fri, 8 Nov 2024 at 15:40, Adriano Cordova adrianox@gmail.com wrote:
From: Heinrich Schuchardt heinrich.schuchardt@canonical.com
Add long texts for
- EFI HTTP Protocol
- EFI HTTP Service Binding Protocol
- EFI IPv4 Configuration II Protocol
to the uuid library.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com Signed-off-by: Adriano Cordova adrianox@gmail.com
lib/uuid.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
diff --git a/lib/uuid.c b/lib/uuid.c index c6a27b7d04..dfc8218fb5 100644 --- a/lib/uuid.c +++ b/lib/uuid.c @@ -174,6 +174,20 @@ static const struct { "Firmware Management", EFI_FIRMWARE_MANAGEMENT_PROTOCOL_GUID }, +#ifdef CONFIG_EFI_HTTP_PROTOCOL
Can you change this to #if IS_ENABLED(...)
Thank you for the suggestion. Not adding all the strings in SPL builds makes sense.
Beyond this patch series some clean-up needed:
There are a lot of other #ifdefs which we probably should replace separately from this series.
We have a symbol CONFIG_SPL_UUID but libuuid is built in SPL irrespective of it.
In vsprintf we only check CONFIG_LIBUUID.
Best regards
Heinrich
{"HTTP",EFI_HTTP_PROTOCOL_GUID,},{"HTTP Service Binding",EFI_HTTP_SERVICE_BINDING_PROTOCOL_GUID,},{"IPv4 Config2",EFI_IP4_CONFIG2_PROTOCOL_GUID,},+#endif /* Configuration table GUIDs */ { "ACPI table", -- 2.43.0
With the above Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org