Re: [U-Boot] [PATCH] drivers/power/regulator/max77686.c: Don't use switch() on bools

Hello Tom,

On 01/17/2016 03:44 AM, Tom Rini wrote:

With gcc-5.3 we get a warning for using switch() on a bool type. Rewrite these sections as if/else and update the one section that was using 1/0 instead of true/false.

Cc: Simon Glass sjg@chromium.org Cc: Przemyslaw Marczak p.marczak@samsung.com Signed-off-by: Tom Rini trini@konsulko.com

---

drivers/power/regulator/max77686.c | 28 ++++++++-------------------- 1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.c index 71678b6..7479af7 100644 --- a/drivers/power/regulator/max77686.c +++ b/drivers/power/regulator/max77686.c @@ -515,25 +515,19 @@ static int max77686_ldo_enable(struct udevice *dev, int op, bool *enable)

switch (on_off) {
case OPMODE_OFF:

• 	*enable = 0;
  

• 	*enable = false;
  break;
  

  case OPMODE_ON:

• 	*enable = 1;
  

• 	*enable = true;
  break;
  

  default: return -EINVAL; } } else if (op == PMIC_OP_SET) {

• switch (*enable) {
  

• case 0:
  

• 	on_off = OPMODE_OFF;
  

• 	break;
  

• case 1:
  

• if (*enable)
  on_off = OPMODE_ON;
  

• 	break;
  

• default:
  

• 	return -EINVAL;
  

• }
  

• else
  

• 	on_off = OPMODE_OFF;
  
  

  ret = max77686_ldo_mode(dev, op, &on_off); if (ret)

@@ -651,16 +645,10 @@ static int max77686_buck_enable(struct udevice *dev, int op, bool *enable) return -EINVAL; } } else if (op == PMIC_OP_SET) {

• switch (*enable) {
  

• case 0:
  

• 	on_off = OPMODE_OFF;
  

• 	break;
  

• case 1:
  

• if (*enable)
  on_off = OPMODE_ON;
  

• 	break;
  

• default:
  

• 	return -EINVAL;
  

• }
  

• else
  

• 	on_off = OPMODE_OFF;
  
  

  ret = max77686_buck_mode(dev, op, &on_off); if (ret)

Thank you for pointing that:)

Acked-by: Przemyslaw Marczak p.marczak@samsung.com

Best regards,