Hi Chris,
On Tue, Nov 3, 2015 at 4:15 AM, Chris Packham judge.packham@gmail.com wrote:
On Tue, Nov 3, 2015 at 9:43 AM, Joe Hershberger joe.hershberger@gmail.com wrote:
Hi Chris,
On Mon, Oct 12, 2015 at 2:43 AM, Chris Packham judge.packham@gmail.com wrote:
Add support for UDP/TFTP over IPv6.
Signed-off-by: Chris Packham judge.packham@gmail.com
One problem with the [hostIpAddr:]fileName syntax is that IPv6 addresses contains colons. So tftp_start() would be confused by 'tftpboot6 $loadaddr 2001:db8::1:zImage'. It is probably possible to change the parsing to separate the host from the filename by parsing from the end (i.e. use strrchr() instead of strchr()) but then there are error cases that may not be handled correctly (e.g. omitting the filename).
I think we should just change the filename separator for tftp6. How about ','?
The other strategy that is often used is to use square brackets to separate the address from other data e.g. http://%5B2001:db8::1%5D:8080/. Maybe that is a better (or at least more common) approach.
Sounds good to me - I'm all for going with a common approach.
common/cmd_net.c | 13 ++++++++++++ include/net6.h | 4 ++++ net/net.c | 3 +++ net/net6.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ net/tftp.c | 37 ++++++++++++++++++++++++++++++++ 5 files changed, 121 insertions(+)
--8<---- snip ----8<--