Hi Heinrich,
On Wed, 18 Jan 2023 at 07:03, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 1/5/23 03:58, Masahisa Kojima wrote:
This series aims to add the vertical scroll for the eficonfig menu. Before adding scroll support, this series does the refactoring of change boot order implementation since it has own menu handling and it should be removed to improve maintenanceability.
%s/maintenanceability/maintainability/
Thank you, I will fix it.
The eficonfig menu handles file selection for EFI load option and secure boot keys, it likely to enumerate tens of files. User can not select the file without scroll if theare are many files under the target directory.
This series only modifies the eficonfig menus. Other menus such as bootmenu is not yet done. We need to enhance the U-Boot menu framework itself if we support other menus.
Masahisa Kojima (3): eficonfig: refactor eficonfig_process_common function eficonfig: refactor change boot order implementation eficonfig: add vertical scroll support
cmd/eficonfig.c | 385 +++++++++++++++++++++++++++++------------- cmd/eficonfig_sbkey.c | 18 +- include/efi_config.h | 17 +- include/efi_loader.h | 1 + 4 files changed, 297 insertions(+), 124 deletions(-)
Due to Simon's patch 32bab0eae51b ("menu: Make use of CLI character processing") this series has to be rebased.
OK, I will rebase.
Please, check if we can set EFICONFIG_ENTRY_NUM_MAX = INT_MAX.
OK.
Thank you for your review.
Regards, Masahisa Kojima
Best regards
Heinrich