Hi Heinrich,
On Mon, 29 Mar 2021 at 01:24, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 3/28/21 4:05 AM, Simon Glass wrote:
On Sun, 28 Mar 2021 at 01:06, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Up to now file_fat_detectfs() did not detect some interface types like EFI, HOST, VIRTIO.
Avoid duplicate code by calling blk_get_if_type_name().
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
fs/fat/fat.c | 36 ++---------------------------------- 1 file changed, 2 insertions(+), 34 deletions(-)
This is lower case I think, but probably that is better anyway.
Reviewed-by: Simon Glass sjg@chromium.org
Thanks for reviewing.
Yes, if_typename_str[] is lowercase. So the case in the output changes. We should avoid different case in different use cases. So this change is favorable.
There is nothing FAT specific in command 'fatinfo'. Shouldn't we better move it to cmd/fs.c and call it 'fsinfo'?
Yes, ultimately the fs commands should use common code. It looks like that has happened with other FAT commands, but not this one.
Regards, Simon