Dear Stefan Roese,
In message 200909171456.33234.sr@denx.de you wrote:
Thanks. I tested it on my faulting ppc4xx platform (sequoia). And the problem is gone now, so thanks.
Thanks for testing.
But I've spotted a problem with other platforms in this patch. See below...
...
-#define ffs +#define PLATFORM_FFS
Here you define "FFS" in upper case.
... which is acctually correct, as macro names _shall_ use upper case letters.
...
-#define __set_bit +#define PLATFORM__set_bit
This is not a legal macro name.
-#define ffs +#define PLATFORM_ffs
Here it's lower case.
Yeah, the patch is not clean.
-#ifndef ffs +#ifndef PLATFORM_ffs # define ffs generic_ffs #endif
And here you check against lower case "_ffs". So the platforms with upper case "_FFS" are still broken. Please fix and resubmit.
Simon, this needs to be cleaned up. Please make sure to use upper case macro names only.
Best regards,
Wolfgang Denk