Re: [U-Boot-Users] [PATCH] Fill in remaining MTD driver data for OneNAND (take #2)

In message 20080806160947.GA2640@ld0162-tx32.am.freescale.net you wrote:

...

• printk(KERN_INFO "%sOneNAND%s %dMB %sV 16-bit (0x%02x)\n",

• sprintf(dev_info, "%sOneNAND%s %dMB %sV 16-bit (0x%02x)", demuxed ? "" : "Muxed ", ddp ? "(DDP)" : "", (16 << density), vcc ? "2.65/3.3" : "1.8", device);

It'd be better to use snprintf, even if you're pretty sure it won't overflow.

This in turn requires that you test the return code for overflowing the buffer - otherwise there is the risk of using an unterminated string.

Best regards,

Wolfgang Denk