Re: [U-Boot] [PATCH 2/3] fsl_pmic: add I2C interface support

On 12/22/2010 02:23 PM, Jason Liu wrote:

This patch add I2C interface for fsl_pmic driver support

+#ifdef CONFIG_FSL_PMIC_I2C +#include <i2c.h> +static int init_done;

+u32 pmic_reg(u32 reg, u32 val, u32 write) +{

• unsigned char buf[4] = { 0 };
• u32 ret_val = 0;
• if (reg > 63 || write > 1) {

• printf("<reg num> = %d is invalid. Should be less then 63\n",
  

• 	reg);
  

• return -1;
  

• }

Probably we can factorize better this function and do not duplicate the pmic_reg function for SPI and I2C.

• if (init_done == 0) {

• i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
  

• init_done = 1;
  

• }
• if (write) {

• buf[0] = (val >> 16) & 0xff;
  

• buf[1] = (val >> 8) & 0xff;
  

• buf[2] = (val) & 0xff;
  

It seems you are converting the endianess. No chance to use an already provided accessor ?

• if (i2c_write(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3))
  

• 	return -1;
  

• } else {

• if (i2c_read(CONFIG_SYS_FSL_PMIC_I2C_ADDR, reg, 1, buf, 3)) {
  

• 	return -1;
  

• ret_val = buf[0] << 16 | buf[1] << 8 | buf[2];
  

Ditto.

Best regards, Stefano Babic