On Mon, Aug 19, 2019 at 10:28:41AM +0200, Eugeniu Rosca wrote:
Hi all,
On Fri, Aug 16, 2019 at 11:46:03AM -0400, David Zeuthen wrote:
Hi, As for upstreaming libavb patches, I'd be interested in landing them upstream... makes it easier for anyone. Our upstream is AOSP and we use gerrit for code-review: https://android-review.googlesource.com/q/project:platform%252Fexternal%252F... Here's a guide to contributing: https://source.android.com/setup/contribute/submit-patches ... hope it's not too painful to use the AOSP process! Thanks, David
David, thanks for being open about discussing/accepting the fixes.
U-Boot folks,
What's your opinion w.r.t. the right/best order between accepting the libavb fixes locally in U-Boot and pushing them to upstream? Which should come first? I suppose they can be first applied internally and replaced later on if they get reworked/optimized during upstreaming.
I think we certainly need to submit the changes upstream first, and then keep our changes in-sync with any feedback we get from upstream. This is just like how we handle DTS changes too.