Re: [PATCH v2 07/10] gpio: rockchip: Use pinctrl pin offset to get_gpio_mux()

Hi Jonas,

On 8/3/24 12:56 AM, Jonas Karlman wrote:

Use the pinctrl pin offset to get_gpio_mux() to remove the bank num dependency and instead only use the bank num to assign a bank name.

Most Rockchip SoCs use all 32 pins of each gpio controller, meaning the pinctrl pin offset typically is aligned to 32.

However, for gpio0 on RK3288 only 24 pins are used meaning the pinctrl pin offset start at pin 24 for gpio1. Use DIV_ROUND_UP to get the 32 pin aligned bank num.

I now see that someone had already opened the can of worms :)

Signed-off-by: Jonas Karlman jonas@kwiboo.se Reviewed-by: Kever Yang kever.yang@rock-chips.com

Reviewed-by: Quentin Schulz quentin.schulz@cherry.de

Thanks! Quentin