Re: [U-Boot] [PATCH 18/31] mpc83xx, kmeter1: add I2C, dtt, eeprom support

Hello Kim,

Kim Phillips wrote:

On Wed, 28 Jan 2009 10:40:04 +0100 Heiko Schocher hs@denx.de wrote:

...

+static int board_init_i2c_busses (void) +{

• I2C_MUX_DEVICE *dev = NULL;
• uchar *buf;
• /* Set up the Bus for the DTTs */
• buf = (unsigned char *) getenv ("DTT_bus");

the environment is case sensitive; can we be more case-consistent with names we expect from it?

Ok.

...

• if (buf != NULL)

• dev = i2c_mux_ident_muxstring (buf);
  

• if (dev == NULL) {

• printf ("Error couldnt add Bus for DTT\n");
  

s/couldnt/couldn't/, add something like "please setenv dtt_bus <insert something reasonable here>"

Ok.

...

• return 0;
  

are you sure you shouldn't be returning an error code? otherwise this line is not necessary.

thanks, Heiko