
Wolfgang,
Dear Andre Schwarz,
In message4CE14E3E.7060208@matrix-vision.de you wrote:
This doesn't seem quite right, the MPC837x has USB controllers.
yes, it has - and it is working fine. But USB register range 0x00-0xff is reserved and hangs the CPU.
With this patch USB is working fine on at least MPC8377.
Then the commit message should make this clear. At the moment it is pretty much misleading.
I didn't add this #ifdef but extended it to not only match 834x but also 837x.
All I see is that the ifdef'ed code accesses registers which are explicitely reserved on MPC834x and at least MPC837x.
What would be an appropriate commit message from your point of view ?
Regards, André
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner