Hi Wolfgang,
On Mon, May 6, 2013 at 2:15 PM, Wolfgang Denk wd@denx.de wrote:
Dear Dirk,
In message 3628fded6de7e6b4286d3444a7e5e3ec@gdsys.cc you wrote:
total: 3 errors, 0 warnings, 509 lines checked
OK, thanks, that makes sense. Which version of checkpatch are you using? Latest u-boot master checkpatch/patman does not show these (at least not for me).
It does for me, interestingly ONLY if the current directory is NOT in the U-Boot tree.
Apparently both the COMPLEX_MACRO and MULTISTATEMENT_MACRO_USE_DO_WHILE option should better be enabled, or we will miss such issues.
Added Joe to Cc: - Joe, what do you think? I'd rather remove the silencing for these from .checkpatch.conf ?
Back in October 2011 checkpatch was generating false positives on COMPLEX_MACRO. If this has been fixed and copied from Linux, then we can certainly stop ignoring it. I reported the issue at that time.
As the .checkpatch.conf comments say, CONFIG_SYS_I2C_NOPROBES definitions were causing false positives with MULTISTATEMENT_MACRO_USE_DO_WHILE. I agree that we can remove ignoring MULTISTATEMENT_MACRO_USE_DO_WHILE as long as the false positives are allowed when identified.
Cheers, -Joe