Re: [U-Boot] [PATCH] image: push default arch values to arch headers

26 Sep 2011


      On Monday, September 26, 2011 02:08:51 Wolfgang Denk wrote:
...
Mike Frysinger wrote:
...
This pushes the ugly duplicated arch ifdef lists we maintain in various
image related files out to the arch headers themselves.
I appreciate this change in general, but ...
...
...
-#else
-# error Unknown CPU type
-#endif

return 0;


return 1;


return !fit_image_check_arch(fdt, node, IH_ARCH_DEFAULT));

...here you change a compile time error check into a runtim error.
no, it'll still be a build time error as IH_ARCH_DEFAULT will be undefined
it just might not be as clean an error ... gcc will complain about 
IH_ARCH_DEFAULT not being defined rather than a helpful "Unknown CPU type" 
message.
-mike