Re: [U-Boot] [PATCH v2 2/2] sunxi: setup simplefb for Allwinner DE2

On Tue, Sep 12, 2017 at 04:25:36PM +0800, icenowy@aosc.io wrote:

在 2017-09-12 16:18，Maxime Ripard 写道：

...

Hi,

On Mon, Sep 11, 2017 at 11:54:58PM +0800, Icenowy Zheng wrote:

...

diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 1373b1f037..c240fe4403 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -288,6 +288,10 @@ extern int soft_i2c_gpio_scl;

#endif /* CONFIG_VIDEO */

+#ifdef CONFIG_VIDEO_DE2 +#define CONFIG_VIDEO_DT_SIMPLEFB +#endif

Please use a Kconfig option for that one.

Should I also convert DE1 simplefb to a Kconfig option?

If you have some spare time, sure, but it's not a pre-requisite for this serie.

Maxime