On Wed, Oct 26, 2022 at 08:30:40AM +0200, Michael Nazzareno Trimarchi wrote:
Hi Roger
On Mon, Oct 10, 2022 at 12:38 PM Roger Quadros rogerq@kernel.org wrote:
+Dario
On 29/09/2022 13:11, Roger Quadros wrote:
OMAP3 BeagleBoard NAND boot hangs when spl_load_legacy_img() tries to read the header into 'struct hdr' which is allocated on the stack.
As the header has already been read once before by spl_nand.c, we can avoid the extra header read here by simply passing around the pointer to the header.
This fixes NAND boot on OMAP3 BeagleBoard.
I can see that fix is only a collateral effect of reduce the allocation on this scenario.
I think that is better to mention as it. So the real change is to avoid to allocate two times mostly
Reviewed-By: Michael Trimarchi michael@amarulasolutions.com
Since I was about to push this out, is it OK to go with this commit message as-is or should I reword it, if Roger doesn't shortly? Thanks.