Re: [PATCH v2 5/8] phy: phy-imx8m-pcie: Add support for i.MX8M{M/P} PCIe PHY

On 2/26/24 1:50 PM, Sumit Garg wrote:

[...]

...

...

• ret = reset_get_by_name(dev, "pciephy", &imx8_phy->reset);
  

• if (ret) {
  

•         dev_err(dev, "Failed to get PCIEPHY reset control\n");
  

•         return ret;
  

• }
  

Some clk_put() and co. fail path is missing here.

Ditto for clk_put() not being available. However, I can add the fail path for the other reset.

Oh, maybe reset_free() and clk_release*() then ?