Hi,
On Fri, 2019-04-26 at 19:57 +0530, Jagan Teki wrote:
On Fri, Apr 26, 2019 at 7:47 PM Paul Kocialkowski paul.kocialkowski@bootlin.com wrote:
Hi,
On Thu, 2019-04-25 at 23:04 +0530, Jagan Teki wrote:
Add initial support for Orangepi RK3399 board.
Specification
- Rockchip RK3399
- 2GB/4GB DDR3
- 16GB eMMC
- SD card slot
Looks like you're missing u-boot,dm-pre-reloc to have it working, which will need to be introduced when moving to rk3399-u-boot.dtsi.
Look like you are confused or doesn't check the patch. This patch have rk3399-orangepi-u-boot.dtsi which included rk3399-u-boot.dtsi that has u-boot,dm-pre-reloc for sdmmc.
Well no, in your v3.1 patch, you no longer have u-boot,dm-pre-reloc in rk3399-u-boot.dtsi, so you need to add it in the device dts and remove it in your second series when you add it back to rk3399-u-boot.dtsi.
It's not okay to submit the board with broken MMC support and fix it in a subsequent series.
Cheers,
Paul