Hi Marek,
On Tue, 17 Feb 2015 20:51:48 +0100 Marek Vasut marex@denx.de wrote:
On Tuesday, February 17, 2015 at 08:00:27 AM, Masahiro Yamada wrote:
Support xHCI host driver used on Panasonic UniPhier platform.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com
Hi Marek,
I want apply this patch onto u-boot-uniphier/master to avoid conflicts.
If you are OK with it, could you issue your Acked-by tag, please?
[...]
+static int get_uniphier_xhci_base(int index, struct xhci_hccr **base) +{
- int offset;
- for (offset = fdt_node_offset_by_compatible(FDT, 0, COMPAT);
offset >= 0;offset = fdt_node_offset_by_compatible(FDT, offset, COMPAT)) {if (index == 0) {*base = (struct xhci_hccr *)fdtdec_get_addr(FDT, offset, "reg");Hi!
does it make sense to check if the value returned by fdtdec_get_addr() is valid here?
Yes. I knew it, but was lazy. Finally, I fixed it in v2.
BTW, why did we invent FDT_ADDR_T_NONE?
We had already had the suitable error code, FDT_ERR_NOTFOUND in libfdt.h (or Linux error code in include/asm-generic/errno.h)
I do not think fdtdec functions are well-implemented.
Best Regards Masahiro Yamada