-----Original Message----- From: Holger Brunck [mailto:holger.brunck@keymile.com] Sent: 12 June 2012 14:04 To: Prafulla Wadaskar Cc: Valentin Longchamp; prafulla@mavell.com; u-boot@lists.denx.de; Gerlando Falauto Subject: Re: [PATCH 04/20] arm/km: add kmnusa board support
On 06/12/2012 06:39 AM, Prafulla Wadaskar wrote:
...snip...
+# End of Header extension
Is this configuration similar to any other board already mainlined?
if there is small delta like RAM/flash sizes then you can manage it through board_init()
Just think of it.
I would like to keep it as it is.
Okay
+DATA 0x0 0x0 diff --git a/board/keymile/km_arm/km_arm.c b/board/keymile/km_arm/km_arm.c index e4ae1fb..ffe13cd 100644 --- a/board/keymile/km_arm/km_arm.c +++ b/board/keymile/km_arm/km_arm.c @@ -133,10 +133,11 @@ int startup_allowed(void) } #endif
-#if (defined(CONFIG_MGCOGE3UN)|defined(CONFIG_PORTL2)) +#if (defined(CONFIG_MGCOGE3UN)|defined(CONFIG_PORTL2)| \
defined(CONFIG_KM_PIGGY4_88E6352))/*
- These two boards have always ethernet present. Its connected to
the mv
- switch.
- All boards with PIGGY4 connected via a simple switch have
ethernet
always
*/
- present.
int ethernet_present(void) { @@ -384,7 +385,7 @@ void reset_phy(void) /* reset the phy */ miiphy_reset(name, CONFIG_PHY_BASE_ADR); } -#else +#elif !defined(CONFIG_KM_PIGGY4_88E6352) /* Configure and enable MV88E1118 PHY on the piggy*/ void reset_phy(void) { diff --git a/boards.cfg b/boards.cfg index b711e0d..1a4c2ad 100644 --- a/boards.cfg +++ b/boards.cfg @@ -140,6 +140,7 @@ pogo_e02 arm
arm926ejs
cloudendns325 arm arm926ejs - d-link kirkwood km_kirkwood arm arm926ejs km_arm keymile kirkwood km_kirkwood:KM_KIRKWOOD,KM_DISABLE_PCI km_kirkwood_pci arm arm926ejs km_arm keymile kirkwood
km_kirkwood:KM_KIRKWOOD_PCI,KM_RECONFIG_XLX
+kmnusa arm arm926ejs km_arm
Why name is not km_nusa?
Could be also km_nusa. But isn't it up to us how we name our boards?
So why your some boards named as kw_xxx and some kmxxx? to me it doesn't sound good.
Anyways the call is yours here.
keymile kirkwood km_kirkwood:KM_NUSA mgcoge3un arm arm926ejs km_arm keymile kirkwood portl2 arm arm926ejs km_arm keymile kirkwood inetspace_v2 arm arm926ejs netspace_v2 LaCie kirkwood lacie_kw:INETSPACE_V2 diff --git a/include/configs/km/km_arm.h
b/include/configs/km/km_arm.h
index 28b5021..a35ef61 100644 --- a/include/configs/km/km_arm.h +++ b/include/configs/km/km_arm.h @@ -57,6 +57,13 @@ #define CONFIG_CMD_SF #define CONFIG_SOFT_I2C /* I2C bit-banged */
+#if defined CONFIG_KM_ENV_IS_IN_SPI_NOR +#define CONFIG_ENV_SPI_BUS 0 +#define CONFIG_ENV_SPI_CS 0 +#define CONFIG_ENV_SPI_MAX_HZ 5000000 +#define CONFIG_ENV_SPI_MODE SPI_MODE_3 +#endif
Do you still need this? Your patch 03/20 takes care of this.
Yes we need it. Patch 03/20 makes it possible to overwrite these default values. And in this patch we use 5MHz as max frequency rather than 50MHz which is the default setting.
So we can only address delta.
Regards.. Prafulla . . .