Re: [U-Boot] [PATCH] arm:kirkwood Wait for the link to come up on kirkwood network init

Dear Ben Warren,

In message 4A8C3172.70001@gmail.com you wrote:

...

• if (!miiphy_link(dev->name, phyadr)) {

• printf("%s: No link on %s\n", __FUNCTION__, dev->name);
  
  

Please use __func__ instead. It's defined in C99, while __FUNCTION__ isn't (or so I've read)

Do we really need the function name at all? This sounds more like a debug message for the developper than a standard error message.

...

• /* Wait up to 5s for the link status */
• for (i = 0; i < 5; i++) {

• u16 phyadr;
  
  

Please put this variable declaration outside of the 'for' loop

Why? If it's only used in this block it's actually a good thing to restrict it to this scope.

Best regards,

Wolfgang Denk