Hi Jan,
On Fri, 28 Jan 2022 at 12:37, Jan Kiszka jan.kiszka@siemens.com wrote:
From: Jan Kiszka jan.kiszka@siemens.com
We can and should run the node generator only when creating a new image. When we read it back, there is no need to generate nodes - they already exits, and binman does not dive that deep into the image - and there is no way to provide the required fdt-list. So store the mode in the image object so that Entry_fit can simply skip generator nodes when reading them from an fdtmap.
This unbreaks all read-backs of images that contain generator nodes in their fdtmap. To confirm this, add a corresponding test case.
Signed-off-by: Jan Kiszka jan.kiszka@siemens.com
tools/binman/etype/fit.py | 2 +- tools/binman/ftest.py | 18 ++++++++++++++++++ tools/binman/image.py | 9 +++++++-- tools/binman/test/219_fit_gennode.dts | 24 ++++++++++++++++++++++++ 4 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 tools/binman/test/219_fit_gennode.dts
(version 3 patch)
Reviewed-by: Simon Glass sjg@chromium.org Tested-by: Simon Glass sjg@chromium.org
This has a lot of merge conflicts but they are my fault, so I am going to tidy them up. PLMK if something looks wrong.
Regards, Simon